diff --git a/constants/fokabotCommands.py b/constants/fokabotCommands.py index e47ad5d..8c9c849 100644 --- a/constants/fokabotCommands.py +++ b/constants/fokabotCommands.py @@ -76,7 +76,7 @@ def alertUser(fro, chan, message): target = message[0].replace("_", " ") targetToken = glob.tokens.getTokenFromUsername(target) - if targetToken != None: + if targetToken is not None: targetToken.enqueue(serverPackets.notification(' '.join(message[1:]))) return False else: @@ -85,7 +85,7 @@ def alertUser(fro, chan, message): def moderated(fro, chan, message): try: # Make sure we are in a channel and not PM - if chan.startswith("#") == False: + if not chan.startswith("#"): raise exceptions.moderatedPMException # Get on/off @@ -104,7 +104,7 @@ def kickAll(fro, chan, message): # Kick everyone but mods/admins toKick = [] for key, value in glob.tokens.tokens.items(): - if value.admin == False: + if not value.admin: toKick.append(key) # Loop though users to kick (we can't change dictionary size while iterating) @@ -120,7 +120,7 @@ def kick(fro, chan, message): # Get target token and make sure is connected targetToken = glob.tokens.getTokenFromUsername(target) - if targetToken == None: + if targetToken is None: return "{} is not online".format(target) # Kick user @@ -131,7 +131,7 @@ def kick(fro, chan, message): def fokabotReconnect(fro, chan, message): # Check if fokabot is already connected - if glob.tokens.getTokenFromUserID(999) != None: + if glob.tokens.getTokenFromUserID(999) is not None: return "Fokabot is already connected to Bancho" # Fokabot is not connected, connect it @@ -151,7 +151,7 @@ def silence(fro, chan, message): userID = userHelper.getID(fro) # Make sure the user exists - if targetUserID == False: + if not targetUserID: return "{}: user not found".format(target) # Calculate silence seconds @@ -172,7 +172,7 @@ def silence(fro, chan, message): # Send silence packet to target if he's connected targetToken = glob.tokens.getTokenFromUsername(target) - if targetToken != None: + if targetToken is not None: # user online, silence both in db and with packet targetToken.silence(silenceTime, reason, userID) else: @@ -192,12 +192,12 @@ def removeSilence(fro, chan, message): # Make sure the user exists targetUserID = userHelper.getID(target) userID = userHelper.getID(fro) - if targetUserID == False: + if not targetUserID: return "{}: user not found".format(target) # Send new silence end packet to user if he's online targetToken = glob.tokens.getTokenFromUsername(target) - if targetToken != None: + if targetToken is not None: # User online, remove silence both in db and with packet targetToken.silence(0, "", userID) else: @@ -215,7 +215,7 @@ def ban(fro, chan, message): # Make sure the user exists targetUserID = userHelper.getID(target) userID = userHelper.getID(fro) - if targetUserID == False: + if not targetUserID: return "{}: user not found".format(target) # Set allowed to 0 @@ -223,7 +223,7 @@ def ban(fro, chan, message): # Send ban packet to the user if he's online targetToken = glob.tokens.getTokenFromUsername(target) - if targetToken != None: + if targetToken is not None: targetToken.enqueue(serverPackets.loginBanned()) log.rap(userID, "has banned {}".format(target), True) @@ -238,7 +238,7 @@ def unban(fro, chan, message): # Make sure the user exists targetUserID = userHelper.getID(target) userID = userHelper.getID(fro) - if targetUserID == False: + if not targetUserID: return "{}: user not found".format(target) # Set allowed to 1 @@ -256,7 +256,7 @@ def restrict(fro, chan, message): # Make sure the user exists targetUserID = userHelper.getID(target) userID = userHelper.getID(fro) - if targetUserID == False: + if not targetUserID: return "{}: user not found".format(target) # Put this user in restricted mode @@ -264,7 +264,7 @@ def restrict(fro, chan, message): # Send restricted mode packet to this user if he's online targetToken = glob.tokens.getTokenFromUsername(target) - if targetToken != None: + if targetToken is not None: targetToken.setRestricted() log.rap(userID, "has put {} in restricted mode".format(target), True) @@ -279,7 +279,7 @@ def unrestrict(fro, chan, message): # Make sure the user exists targetUserID = userHelper.getID(target) userID = userHelper.getID(fro) - if targetUserID == False: + if not targetUserID: return "{}: user not found".format(target) # Set allowed to 1 @@ -331,14 +331,14 @@ def systemMaintenance(fro, chan, message): # Set new maintenance value in bancho_settings table glob.banchoConf.setMaintenance(maintenance) - if maintenance == True: + if maintenance: # We have turned on maintenance mode # Users that will be disconnected who = [] # Disconnect everyone but mod/admins for _, value in glob.tokens.tokens.items(): - if value.admin == False: + if not value.admin: who.append(value.userID) glob.tokens.enqueueAll(serverPackets.notification("Our bancho server is in maintenance mode. Please try to login again later.")) @@ -368,7 +368,7 @@ def systemStatus(fro, chan, message): msg += "=== SYSTEM STATS ===\n" msg += "CPU: {}%\n".format(data["cpuUsage"]) msg += "RAM: {}GB/{}GB\n".format(data["usedMemory"], data["totalMemory"]) - if data["unix"] == True: + if data["unix"]: msg += "Load average: {}/{}/{}\n".format(data["loadAverage"][0], data["loadAverage"][1], data["loadAverage"][2]) return msg @@ -378,7 +378,7 @@ def getPPMessage(userID, just_data = False): try: # Get user token token = glob.tokens.getTokenFromUserID(userID) - if token == None: + if token is None: return False currentMap = token.tillerino[0] @@ -477,7 +477,7 @@ def tillerinoNp(fro, chan, message): # Update latest tillerino song for current token token = glob.tokens.getTokenFromUsername(fro) - if token != None: + if token is not None: token.tillerino = [int(beatmapID), modsEnum, -1.0] userID = token.userID @@ -495,7 +495,7 @@ def tillerinoMods(fro, chan, message): # Get token and user ID token = glob.tokens.getTokenFromUsername(fro) - if token == None: + if token is None: return False userID = token.userID @@ -547,7 +547,7 @@ def tillerinoAcc(fro, chan, message): # Get token and user ID token = glob.tokens.getTokenFromUsername(fro) - if token == None: + if token is None: return False userID = token.userID @@ -578,12 +578,12 @@ def tillerinoLast(fro, chan, message): WHERE users.username = %s ORDER BY scores.time DESC LIMIT 1""", [fro]) - if data == None: + if data is None: return False diffString = "difficulty_{}".format(gameModes.getGameModeForDB(data["play_mode"])) - rank = generalFunctions.getRank(data["play_mode"], data["mods"], data["accuracy"],\ - data["300_count"], data["100_count"], data["50_count"], data["misses_count"]) + rank = generalFunctions.getRank(data["play_mode"], data["mods"], data["accuracy"], + data["300_count"], data["100_count"], data["50_count"], data["misses_count"]) ifPlayer = "{0} | ".format(fro) if chan != "FokaBot" else "" ifFc = " (FC)" if data["max_combo"] == data["fc"] else " {0}x/{1}x".format(data["max_combo"], data["fc"]) @@ -614,7 +614,7 @@ def tillerinoLast(fro, chan, message): stars = data[diffString] if data["mods"]: token = glob.tokens.getTokenFromUsername(fro) - if token == None: + if token is None: return False userID = token.userID token.tillerino[0] = data["bid"] diff --git a/constants/serverPackets.py b/constants/serverPackets.py index d64fdd0..d069f8d 100644 --- a/constants/serverPackets.py +++ b/constants/serverPackets.py @@ -44,9 +44,9 @@ def mainMenuIcon(icon): def userSupporterGMT(supporter, GMT): result = 1 - if supporter == True: + if supporter: result += 4 - if GMT == True: + if GMT: result += 2 return packetHelper.buildPacket(packetIDs.server_supporterGMT, [[result, dataTypes.UINT32]]) @@ -60,7 +60,7 @@ def onlineUsers(): # Create list with all connected (and not restricted) users for _, value in users.items(): - if value.restricted == False: + if not value.restricted: userIDs.append(value.userID) return packetHelper.buildPacket(packetIDs.server_userPresenceBundle, [[userIDs, dataTypes.INT_LIST]]) @@ -73,7 +73,7 @@ def userLogout(userID): def userPanel(userID, force = False): # Connected and restricted check userToken = glob.tokens.getTokenFromUserID(userID) - if userToken == None: + if userToken is None: return bytes() if userToken.restricted == True and force == False: return bytes() @@ -90,9 +90,9 @@ def userPanel(userID, force = False): # Only admins and normal users are currently supported if username == "FokaBot": userRank = userRanks.MOD - elif userHelper.isInPrivilegeGroup(userID, "community manager") == True: + elif userHelper.isInPrivilegeGroup(userID, "community manager"): userRank = userRanks.MOD - elif userHelper.isInPrivilegeGroup(userID, "developer") == True: + elif userHelper.isInPrivilegeGroup(userID, "developer"): userRank = userRanks.ADMIN elif (userToken.privileges & privileges.USER_DONOR) > 0: userRank = userRanks.SUPPORTER @@ -116,7 +116,7 @@ def userStats(userID, force = False): # Get userID's token from tokens list userToken = glob.tokens.getTokenFromUserID(userID) - if userToken == None: + if userToken is None: return bytes() if (userToken.restricted == True or userToken.irc == True) and force == False: return bytes() diff --git a/events/cantSpectateEvent.py b/events/cantSpectateEvent.py index 15f887f..862bdbf 100644 --- a/events/cantSpectateEvent.py +++ b/events/cantSpectateEvent.py @@ -3,7 +3,7 @@ from constants import serverPackets from constants import exceptions from helpers import logHelper as log -def handle(userToken, packetData): +def handle(userToken, _): # get usertoken data userID = userToken.userID diff --git a/events/changeActionEvent.py b/events/changeActionEvent.py index 2cc1412..24de2ca 100644 --- a/events/changeActionEvent.py +++ b/events/changeActionEvent.py @@ -11,13 +11,13 @@ def handle(userToken, packetData): username = userToken.username # Make sure we are not banned - if userHelper.isBanned(userID) == True: + if userHelper.isBanned(userID): userToken.enqueue(serverPackets.loginBanned()) return # Send restricted message if needed - if userToken.restricted == False: - if userHelper.isRestricted(userID) == True: + if not userToken.restricted: + if userHelper.isRestricted(userID): userToken.setRestricted() # Change action packet @@ -55,7 +55,7 @@ def handle(userToken, packetData): else: token = glob.tokens.getTokenFromUserID(i) - if token != None: + if token is not None: # Force our own packet force = True if token.userID == userID else False token.enqueue(serverPackets.userPanel(userID, force)) diff --git a/events/changeMatchModsEvent.py b/events/changeMatchModsEvent.py index 183f65d..f5d218b 100644 --- a/events/changeMatchModsEvent.py +++ b/events/changeMatchModsEvent.py @@ -40,7 +40,7 @@ def handle(userToken, packetData): # Set slot mods slotID = match.getUserSlotID(userID) - if slotID != None: + if slotID is not None: match.setSlotMods(slotID, packetData["mods"]) else: # Not freemod, set match mods diff --git a/events/createMatchEvent.py b/events/createMatchEvent.py index 8f8df8a..3bca2db 100644 --- a/events/createMatchEvent.py +++ b/events/createMatchEvent.py @@ -34,7 +34,7 @@ def handle(userToken, packetData): for i in glob.matches.usersInLobby: # Make sure this user is still connected token = glob.tokens.getTokenFromUserID(i) - if token != None: + if token is not None: token.enqueue(serverPackets.createMatch(matchID)) # Console output diff --git a/events/joinMatchEvent.py b/events/joinMatchEvent.py index 624a5ee..9693cfa 100644 --- a/events/joinMatchEvent.py +++ b/events/joinMatchEvent.py @@ -45,7 +45,7 @@ def joinMatch(userToken, matchID, password, isPasswordHashed = False): result = match.userJoin(userID) # Check if we've joined the match successfully - if result == False: + if not result: raise exceptions.matchJoinErrorException # Match joined, set matchID for usertoken diff --git a/events/loginEvent.py b/events/loginEvent.py index b544e41..b261c25 100644 --- a/events/loginEvent.py +++ b/events/loginEvent.py @@ -52,10 +52,10 @@ def handle(tornadoRequest): username = str(loginData[0]) userID = userHelper.getID(username) - if userID == False: + if not userID: # Invalid username raise exceptions.loginFailedException() - if userHelper.checkLogin(userID, loginData[1]) == False: + if not userHelper.checkLogin(userID, loginData[1]): # Invalid password raise exceptions.loginFailedException() @@ -65,7 +65,7 @@ def handle(tornadoRequest): raise exceptions.loginBannedException() # 2FA check - if userHelper.check2FA(userID, requestIP) == True: + if userHelper.check2FA(userID, requestIP): log.warning("Need 2FA check for user {}".format(loginData[0])) raise exceptions.need2FAException() @@ -74,7 +74,7 @@ def handle(tornadoRequest): # Verify this user (if pending activation) firstLogin = False if priv & privileges.USER_PENDING_VERIFICATION > 0 or userHelper.hasVerifiedHardware(userID) == False: - if userHelper.verifyUser(userID, clientData) == True: + if userHelper.verifyUser(userID, clientData): # Valid account log.info("Account {} verified successfully!".format(userID)) glob.verifiedCache[str(userID)] = 1 @@ -92,7 +92,7 @@ def handle(tornadoRequest): # This is false only if HWID is empty # if HWID is banned, we get restricted so there's no # need to deny bancho access - if hwAllowed == False: + if not hwAllowed: raise exceptions.haxException() # Log user IP @@ -115,11 +115,11 @@ def handle(tornadoRequest): # Get supporter/GMT userGMT = False userSupporter = True - if responseToken.admin == True: + if responseToken.admin: userGMT = True # Server restarting check - if glob.restarting == True: + if glob.restarting: raise exceptions.banchoRestartingException() # Send login notification before maintenance message @@ -127,8 +127,8 @@ def handle(tornadoRequest): responseToken.enqueue(serverPackets.notification(glob.banchoConf.config["loginNotification"])) # Maintenance check - if glob.banchoConf.config["banchoMaintenance"] == True: - if userGMT == False: + if glob.banchoConf.config["banchoMaintenance"]: + if not userGMT: # We are not mod/admin, delete token, send notification and logout glob.tokens.deleteToken(responseTokenString) raise exceptions.banchoMaintenanceException() @@ -152,7 +152,7 @@ def handle(tornadoRequest): chat.joinChannel(token=responseToken, channel="#announce") # Join admin channel if we are an admin - if responseToken.admin == True: + if responseToken.admin: chat.joinChannel(token=responseToken, channel="#admin") # Output channels info @@ -171,7 +171,7 @@ def handle(tornadoRequest): responseToken.enqueue(serverPackets.onlineUsers()) # Get location and country from ip.zxq.co or database - if glob.localize == True: + if glob.localize: # Get location and country from IP location = locationHelper.getLocation(requestIP) countryLetters = locationHelper.getCountry(requestIP) @@ -192,7 +192,7 @@ def handle(tornadoRequest): userHelper.setCountry(userID, countryLetters) # Send to everyone our userpanel if we are not restricted - if responseToken.restricted == False: + if not responseToken.restricted: glob.tokens.enqueueAll(serverPackets.userPanel(userID)) # Set reponse data to right value and reset our queue @@ -242,4 +242,4 @@ def handle(tornadoRequest): log.info(msg, "bunker") # Return token string and data - return (responseTokenString, responseData) \ No newline at end of file + return responseTokenString, responseData \ No newline at end of file diff --git a/events/matchFramesEvent.py b/events/matchFramesEvent.py index f47f8c1..68179c0 100644 --- a/events/matchFramesEvent.py +++ b/events/matchFramesEvent.py @@ -27,5 +27,5 @@ def handle(userToken, packetData): for i in range(0,16): if match.slots[i].userID > -1 and match.slots[i].status == slotStatuses.playing: token = glob.tokens.getTokenFromUserID(match.slots[i].userID) - if token != None: + if token is not None: token.enqueue(serverPackets.matchFrames(slotID, packetData)) diff --git a/events/matchReadyEvent.py b/events/matchReadyEvent.py index 77d743d..eb24ced 100644 --- a/events/matchReadyEvent.py +++ b/events/matchReadyEvent.py @@ -12,5 +12,5 @@ def handle(userToken, _): # Get our slotID and change ready status slotID = match.getUserSlotID(userID) - if slotID != None: + if slotID is not None: match.toggleSlotReady(slotID) diff --git a/events/matchStartEvent.py b/events/matchStartEvent.py index f3cd9d6..777b12f 100644 --- a/events/matchStartEvent.py +++ b/events/matchStartEvent.py @@ -23,7 +23,7 @@ def handle(userToken, _): return # Make sure we have enough players - if (match.countUsers() < 2 or match.checkTeams() == False): + if match.countUsers() < 2 or match.checkTeams() == False: return # Change inProgress value @@ -41,7 +41,7 @@ def handle(userToken, _): for i in range(0,16): if (match.slots[i].status & slotStatuses.playing) > 0 and match.slots[i].userID != -1: token = glob.tokens.getTokenFromUserID(match.slots[i].userID) - if token != None: + if token is not None: token.enqueue(serverPackets.matchStart(matchID)) # Send updates diff --git a/events/spectateFramesEvent.py b/events/spectateFramesEvent.py index 0abe409..3e4c680 100644 --- a/events/spectateFramesEvent.py +++ b/events/spectateFramesEvent.py @@ -15,7 +15,7 @@ def handle(userToken, packetData): spectatorToken = glob.tokens.getTokenFromUserID(i) # Make sure the token exists - if spectatorToken == None: + if spectatorToken is None: raise exceptions.stopSpectating # Make sure this user is spectating us diff --git a/events/startSpectatingEvent.py b/events/startSpectatingEvent.py index 9bbddcb..4cd82df 100644 --- a/events/startSpectatingEvent.py +++ b/events/startSpectatingEvent.py @@ -26,7 +26,7 @@ def handle(userToken, packetData): # Get host token targetToken = glob.tokens.getTokenFromUserID(packetData["userID"]) - if targetToken == None: + if targetToken is None: raise exceptions.tokenNotFoundException # Add us to host's spectators diff --git a/handlers/apiFokabotMessageHandler.py b/handlers/apiFokabotMessageHandler.py index 7024fb6..3314ef9 100644 --- a/handlers/apiFokabotMessageHandler.py +++ b/handlers/apiFokabotMessageHandler.py @@ -11,7 +11,7 @@ class handler(requestHelper.asyncRequestHandler): data = {"message": "unknown error"} try: # Check arguments - if requestHelper.checkArguments(self.request.arguments, ["k", "to", "msg"]) == False: + if not requestHelper.checkArguments(self.request.arguments, ["k", "to", "msg"]): raise exceptions.invalidArgumentsException() # Check ci key diff --git a/handlers/apiIsOnlineHandler.py b/handlers/apiIsOnlineHandler.py index b443821..e62cc0b 100644 --- a/handlers/apiIsOnlineHandler.py +++ b/handlers/apiIsOnlineHandler.py @@ -23,13 +23,13 @@ class handler(requestHelper.asyncRequestHandler): except: raise exceptions.invalidArgumentsException() - if username == None and userID == None: + if username is None and userID is None: data["result"] = False else: - if username != None: - data["result"] = True if glob.tokens.getTokenFromUsername(username) != None else False + if username is not None: + data["result"] = True if glob.tokens.getTokenFromUsername(username) is not None else False else: - data["result"] = True if glob.tokens.getTokenFromUserID(userID) != None else False + data["result"] = True if glob.tokens.getTokenFromUserID(userID) is not None else False # Status code and message statusCode = 200 diff --git a/handlers/apiVerifiedStatusHandler.py b/handlers/apiVerifiedStatusHandler.py index bc23526..35f0994 100644 --- a/handlers/apiVerifiedStatusHandler.py +++ b/handlers/apiVerifiedStatusHandler.py @@ -10,7 +10,7 @@ class handler(requestHelper.asyncRequestHandler): data = {"message": "unknown error"} try: # Check arguments - if requestHelper.checkArguments(self.request.arguments, ["u"]) == False: + if not requestHelper.checkArguments(self.request.arguments, ["u"]): raise exceptions.invalidArgumentsException() # Get userID and its verified cache thing diff --git a/handlers/ciTriggerHandler.py b/handlers/ciTriggerHandler.py index d2b15f6..3724baf 100644 --- a/handlers/ciTriggerHandler.py +++ b/handlers/ciTriggerHandler.py @@ -11,7 +11,7 @@ class handler(requestHelper.asyncRequestHandler): data = {"message": "unknown error"} try: # Check arguments - if requestHelper.checkArguments(self.request.arguments, ["k"]) == False: + if not requestHelper.checkArguments(self.request.arguments, ["k"]): raise exceptions.invalidArgumentsException() # Check ci key diff --git a/handlers/mainHandler.py b/handlers/mainHandler.py index 90d36bf..4d4e325 100644 --- a/handlers/mainHandler.py +++ b/handlers/mainHandler.py @@ -60,7 +60,7 @@ class handler(SentryMixin, requestHelper.asyncRequestHandler): def asyncPost(self): try: # Track time if needed - if glob.outputRequestTime == True: + if glob.outputRequestTime: # Start time st = datetime.datetime.now() @@ -70,9 +70,8 @@ class handler(SentryMixin, requestHelper.asyncRequestHandler): # Server's token string and request data responseTokenString = "ayy" - responseData = bytes() - if requestTokenString == None: + if requestTokenString is None: # No token, first request. Handle login. responseTokenString, responseData = loginEvent.handle(self) else: @@ -198,10 +197,10 @@ class handler(SentryMixin, requestHelper.asyncRequestHandler): log.info("{} has been disconnected (invalid token)".format(requestTokenString)) finally: # Unlock token - if userToken != None: + if userToken is not None: userToken.lock.release() - if glob.outputRequestTime == True: + if glob.outputRequestTime: # End time et = datetime.datetime.now() @@ -211,7 +210,7 @@ class handler(SentryMixin, requestHelper.asyncRequestHandler): # Send server's response to client # We don't use token object because we might not have a token (failed login) - if glob.gzip == True: + if glob.gzip: # First, write the gzipped response self.write(gzip.compress(responseData, int(glob.conf.config["server"]["gziplevel"]))) diff --git a/helpers/chatHelper.py b/helpers/chatHelper.py index e767f14..80df511 100644 --- a/helpers/chatHelper.py +++ b/helpers/chatHelper.py @@ -23,10 +23,10 @@ def joinChannel(userID = 0, channel = "", token = None, toIRC = True): """ try: # Get token if not defined - if token == None: + if token is None: token = glob.tokens.getTokenFromUserID(userID) # Make sure the token exists - if token == None: + if token is None: raise exceptions.userNotFoundException else: token = token @@ -89,10 +89,10 @@ def partChannel(userID = 0, channel = "", token = None, toIRC = True, kick = Fal """ try: # Get token if not defined - if token == None: + if token is None: token = glob.tokens.getTokenFromUserID(userID) # Make sure the token exists - if token == None: + if token is None: raise exceptions.userNotFoundException else: token = token @@ -128,7 +128,7 @@ def partChannel(userID = 0, channel = "", token = None, toIRC = True, kick = Fal # Force close tab if needed # NOTE: Maybe always needed, will check later - if kick == True: + if kick: token.enqueue(serverPackets.channelKicked(channelClient)) # IRC part @@ -164,9 +164,9 @@ def sendMessage(fro = "", to = "", message = "", token = None, toIRC = True): try: tokenString = "" # Get token object if not passed - if token == None: + if token is None: token = glob.tokens.getTokenFromUsername(fro) - if token == None: + if token is None: raise exceptions.userNotFoundException else: # token object alredy passed, get its string and its username (fro) @@ -176,14 +176,13 @@ def sendMessage(fro = "", to = "", message = "", token = None, toIRC = True): # Set some variables userID = token.userID username = token.username - recipients = [] # Make sure the user is not in restricted mode - if token.restricted == True: + if token.restricted: raise exceptions.userRestrictedException # Make sure the user is not silenced - if token.isSilenced() == True: + if token.isSilenced(): raise exceptions.userSilencedException # Determine internal name if needed @@ -213,7 +212,7 @@ def sendMessage(fro = "", to = "", message = "", token = None, toIRC = True): # Send the message isChannel = to.startswith("#") - if isChannel == True: + if isChannel: # CHANNEL # Make sure the channel exists if to not in glob.channels.channels: @@ -240,7 +239,7 @@ def sendMessage(fro = "", to = "", message = "", token = None, toIRC = True): # USER # Make sure recipient user is connected recipientToken = glob.tokens.getTokenFromUsername(to) - if recipientToken == None: + if recipientToken is None: raise exceptions.userNotFoundException # Make sure the recipient is not restricted or we are FokaBot @@ -267,11 +266,11 @@ def sendMessage(fro = "", to = "", message = "", token = None, toIRC = True): # Fokabot message if isChannel == True or to.lower() == "fokabot": fokaMessage = fokabot.fokabotResponse(username, to, message) - if fokaMessage != False: + if fokaMessage: sendMessage("FokaBot", to if isChannel else fro, fokaMessage) # File and discord logs (public chat only) - if to.startswith("#") == True: + if to.startswith("#"): log.chat("{fro} @ {to}: {message}".format(fro=username, to=to, message=str(message.encode("utf-8")))) discordBotHelper.sendChatlog("**{fro} @ {to}:** {message}".format(fro=username, to=to, message=str(message.encode("utf-8"))[2:-1])) return 0 @@ -305,7 +304,7 @@ def fixUsernameForIRC(username): def IRCConnect(username): userID = userHelper.getID(username) - if userID == False: + if not userID: log.warning("{} doesn't exist".format(username)) return glob.tokens.deleteOldTokens(userID) @@ -315,7 +314,7 @@ def IRCConnect(username): def IRCDisconnect(username): token = glob.tokens.getTokenFromUsername(username) - if token == None: + if token is None: log.warning("{} doesn't exist".format(username)) return logoutEvent.handle(token) @@ -323,7 +322,7 @@ def IRCDisconnect(username): def IRCJoinChannel(username, channel): userID = userHelper.getID(username) - if userID == False: + if not userID: log.warning("{} doesn't exist".format(username)) return # NOTE: This should have also `toIRC` = False` tho, @@ -333,7 +332,7 @@ def IRCJoinChannel(username, channel): def IRCPartChannel(username, channel): userID = userHelper.getID(username) - if userID == False: + if not userID: log.warning("{} doesn't exist".format(username)) return return partChannel(userID, channel) diff --git a/helpers/configHelper.py b/helpers/configHelper.py index 2bb0ca8..456ab07 100644 --- a/helpers/configHelper.py +++ b/helpers/configHelper.py @@ -1,7 +1,7 @@ import os import configparser -class config(): +class config: # Check if config.ini exists and load/generate it def __init__(self, file): """ diff --git a/helpers/consoleHelper.py b/helpers/consoleHelper.py index 80abcd5..cccf12e 100644 --- a/helpers/consoleHelper.py +++ b/helpers/consoleHelper.py @@ -7,7 +7,7 @@ def printServerStartHeader(asciiArt): asciiArt -- if True, will print ascii art too """ - if asciiArt == True: + if asciiArt: print("{} _ __".format(bcolors.GREEN)) print(" (_) / /") print(" ______ __ ____ ____ / /____") diff --git a/helpers/databaseHelperNew.py b/helpers/databaseHelperNew.py index 1e3d811..6610295 100644 --- a/helpers/databaseHelperNew.py +++ b/helpers/databaseHelperNew.py @@ -2,7 +2,7 @@ import MySQLdb import threading from helpers import logHelper as log -class mysqlWorker(): +class mysqlWorker: """ Instance of a mysql worker """ @@ -22,7 +22,7 @@ class mysqlWorker(): self.ready = True self.lock = threading.Lock() -class db(): +class db: """ A MySQL db connection with multiple workers """ @@ -78,7 +78,7 @@ class db(): cursor.close() worker.lock.release() - def fetch(self, query, params = (), all = False): + def fetch(self, query, params = (), all_ = False): """ Fetch a single value from db that matches given query @@ -95,7 +95,7 @@ class db(): # Create cursor, execute the query and fetch one/all result(s) cursor = worker.connection.cursor(MySQLdb.cursors.DictCursor) cursor.execute(query, params) - if all == True: + if all_: return cursor.fetchall() else: return cursor.fetchone() diff --git a/helpers/discordBotHelper.py b/helpers/discordBotHelper.py index d9c5f31..fa3ca0f 100644 --- a/helpers/discordBotHelper.py +++ b/helpers/discordBotHelper.py @@ -12,7 +12,7 @@ def sendDiscordMessage(channel, message, alertDev = False, prefix = "**pep.py**" alertDev -- if True, hl developers group prefix -- string to prepend to message """ - if glob.discord == True: + if glob.discord: for _ in range(0,20): try: finalMsg = "{prefix} {message}".format(prefix=prefix, message=message) if alertDev == False else "{prefix} {hl} - {message}".format(prefix=prefix, hl=glob.conf.config["discord"]["devgroup"], message=message) diff --git a/helpers/generalFunctions.py b/helpers/generalFunctions.py index 88f98aa..da00010 100644 --- a/helpers/generalFunctions.py +++ b/helpers/generalFunctions.py @@ -20,7 +20,7 @@ def stringToBool(s): s -- string/int value return -- True/False """ - return (s == "True" or s== "true" or s == "1" or s == 1) + return s == "True" or s == "true" or s == "1" or s == 1 def hexString(s): """ diff --git a/helpers/logHelper.py b/helpers/logHelper.py index 963377a..bf8d357 100644 --- a/helpers/logHelper.py +++ b/helpers/logHelper.py @@ -47,11 +47,11 @@ def logMessage(message, alertType = "INFO", messageColor = bcolors.ENDC, discord endc=bcolors.ENDC) # Log to console - if stdout == True: + if stdout: print(finalMessageConsole) # Log to discord if needed - if discord != None: + if discord is not None: if discord == "bunker": discordBotHelper.sendConfidential(message, alertDev) elif discord == "cm": @@ -62,7 +62,7 @@ def logMessage(message, alertType = "INFO", messageColor = bcolors.ENDC, discord discordBotHelper.sendGeneral(message) # Log to file if needed - if of != None: + if of is not None: try: glob.fLocks.lockFile(of) with open(".data/{}".format(of), "a") as f: @@ -106,7 +106,7 @@ def debug(message): message -- debug message """ - if glob.debug == True: + if glob.debug: logMessage(message, "DEBUG", bcolors.PINK) def chat(message): @@ -135,6 +135,6 @@ def rap(userID, message, discord=False, through="FokaBot"): through -- "through" thing string. Optional. Default: "FokaBot" """ glob.db.execute("INSERT INTO rap_logs (id, userid, text, datetime, through) VALUES (NULL, %s, %s, %s, %s)", [userID, message, int(time.time()), through]) - if discord == True: + if discord: username = userHelper.getUsername(userID) logMessage("{} {}".format(username, message), discord=True) diff --git a/helpers/packetHelper.py b/helpers/packetHelper.py index 4be8c88..4f807b8 100644 --- a/helpers/packetHelper.py +++ b/helpers/packetHelper.py @@ -16,9 +16,9 @@ def uleb128Encode(num): while num > 0: arr.append(num & 127) - num = num >> 7 + num >>= 7 if num != 0: - arr[length] = arr[length] | 128 + arr[length] |= 128 length+=1 return arr @@ -36,7 +36,7 @@ def uleb128Decode(num): while True: b = num[arr[1]] arr[1]+=1 - arr[0] = arr[0] | (int(b & 127) << shift) + arr[0] |= int(b & 127) << shift if b & 128 == 0: break shift += 7 @@ -133,12 +133,12 @@ def packData(__data, dataType): packType = "