Fix PP calculation with certain mod combinations (#3)

* specify mods before acc

* fix ownership of calculator

* v0.7.2
This commit is contained in:
James
2022-07-16 20:20:25 +01:00
committed by GitHub
parent 30147706cc
commit d84a7d8dcb
3 changed files with 7 additions and 2 deletions
+3
View File
@@ -1,3 +1,6 @@
# v0.7.2 (2022-07-16)
- Apply acc before mods to fix pp values sometimes calculating incorrectly on certain mod combos
# v0.7.1 (2022-07-12)
- Updated to [rosu-pp v0.7.1](https://github.com/MaxOhn/rosu-pp/blob/main/CHANGELOG.md#v071-2022-07-12)
+1 -1
View File
@@ -4,7 +4,7 @@ build-backend = "maturin"
[project]
name = "rosu-pp-py"
version = "0.7.1"
version = "0.7.2"
requires-python = ">=3.7"
description = "osu! difficulty and pp calculation for all modes"
classifiers = [
+3 -1
View File
@@ -546,6 +546,8 @@ impl ScoreParams {
calculator = calculator.clock_rate(clock_rate);
}
calculator = calculator.mods(mods);
if let Some(acc) = acc {
calculator = calculator.accuracy(acc);
}
@@ -554,7 +556,7 @@ impl ScoreParams {
calculator = calculator.score(score);
}
calculator.mods(mods)
calculator
}
}